Ulan, could you please take a look.Also do you know a non-flaky way to obtain a weak FixedArray container on a heap
object for the test purposes?
Thanks https://codereview.chromium.org/213673006/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/213673006/diff/1/src/heap-snapshot-generator.cc#newcode1152 src/heap-snapshot-generator.cc:1152: HeapEntry* heap_entry = GetEntry(obj); On 2014/04/01 15:51:55, yurys wrote:
Consider extracting common prologue and epilogue of
ExtractReferencesPass{1,2}
into IterateAndExtractSinglePass.
Done. https://codereview.chromium.org/213673006/diff/1/src/heap-snapshot-generator.cc#newcode2189 src/heap-snapshot-generator.cc:2189: if (IsEssentialObject(object)) { On 2014/04/01 15:51:55, yurys wrote:
Can you add an assert that the object passed in is a FixedArray or
change the
parameter type to FixedArray?
Done. https://codereview.chromium.org/213673006/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
