Revision: 20412
Author: [email protected]
Date: Tue Apr 1 18:04:06 2014 UTC
Log: Remove V8_INLINE to prevent C4714 warning under Win64.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/217123004
Patch from Daniel Vogelheim <[email protected]>.
http://code.google.com/p/v8/source/detail?r=20412
Modified:
/branches/bleeding_edge/include/v8-util.h
/branches/bleeding_edge/include/v8.h
=======================================
--- /branches/bleeding_edge/include/v8-util.h Mon Mar 31 10:03:20 2014 UTC
+++ /branches/bleeding_edge/include/v8-util.h Tue Apr 1 18:04:06 2014 UTC
@@ -210,7 +210,7 @@
/**
* Return value for key and remove it from the map.
*/
- V8_INLINE UniquePersistent<V> Remove(const K& key) {
+ UniquePersistent<V> Remove(const K& key) {
return Release(Traits::Remove(&impl_, key)).Pass();
}
@@ -357,7 +357,7 @@
* callback is properly disposed of. All remove functionality should go
* through this.
*/
- V8_INLINE static UniquePersistent<V> Release(PersistentContainerValue v)
{
+ static UniquePersistent<V> Release(PersistentContainerValue v) {
UniquePersistent<V> p;
p.val_ = FromVal(v);
if (Traits::kCallbackType != kNotWeak && !p.IsEmpty()) {
=======================================
--- /branches/bleeding_edge/include/v8.h Tue Apr 1 12:34:08 2014 UTC
+++ /branches/bleeding_edge/include/v8.h Tue Apr 1 18:04:06 2014 UTC
@@ -814,7 +814,7 @@
/**
* Pass allows returning uniques from functions, etc.
*/
- V8_INLINE UniquePersistent Pass() { return
UniquePersistent(RValue(this)); }
+ UniquePersistent Pass() { return UniquePersistent(RValue(this)); }
private:
UniquePersistent(UniquePersistent&);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
