lgtm.
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py
File tools/push-to-trunk/auto_roll.py (right):
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py#newcode93
tools/push-to-trunk/auto_roll.py:93: print "A author (-a) is required."
Nit: "A" -> "An"
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (right):
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/common_includes.py#newcode260
tools/push-to-trunk/common_includes.py:260: print ">>> Step %d: %s" %
(self._number, self._text)
Why is the printing inside the try block? Can it fail?
https://codereview.chromium.org/212983003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
