Reviewers: Michael Achenbach,
Description:
Make build/gyp_v8 cope with ninja on linux
ninja doesn't support/need the output dir and generator dir flags
BUG=v8:3252
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/222023004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M build/gyp_v8
Index: build/gyp_v8
diff --git a/build/gyp_v8 b/build/gyp_v8
index
f2a60d1b2c8d381b780a89439b16f95d216d5cb7..bc733dfca6fceb3da58e0e7ca5e4a380de1cf03c
100755
--- a/build/gyp_v8
+++ b/build/gyp_v8
@@ -158,7 +158,8 @@ if __name__ == '__main__':
# Generate for the architectures supported on the given platform.
gyp_args = list(args)
- if platform.system() == 'Linux':
+ gyp_generators = os.environ.get('GYP_GENERATORS')
+ if platform.system() == 'Linux' and gyp_generators != 'ninja':
# Work around for crbug.com/331475.
for f in glob.glob(os.path.join(v8_root, 'out', 'Makefile.*')):
os.unlink(f)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
