Drive-by comments.
https://codereview.chromium.org/222163002/diff/20001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode38
src/handles.h:38: class MaybeHandle {
Can we get a few comments above this class about why we have it and what
distinguishes it from an ordinary Handle?
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode94
src/handles.h:94: INLINE(Handle()) {}
As discussed offline: The ultimate goal of this endeavor is to get rid
of this constructor. I totally understand that this will take some time,
but can we leave a TODO here in that regard? Without reaching this goal,
all the changes leading up to it would increase complexity instead of
reducing it.
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode124
src/handles.h:124: static Handle<T> null() { return Handle<T>(); }
Likewise.
https://codereview.chromium.org/222163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
