Reviewers: Toon Verwaest,
Description:
Remove dead Object::GetPropertyOrFail.
[email protected]
Please review this at https://codereview.chromium.org/215973004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -26 lines):
M src/heap-inl.h
M src/objects.h
M src/objects.cc
Index: src/heap-inl.h
diff --git a/src/heap-inl.h b/src/heap-inl.h
index
063cf30ff3cd178b4c7efda22fcc2447252e90c8..277f9c448dc911bedd9d7ee7d26c5f887bab5357
100644
--- a/src/heap-inl.h
+++ b/src/heap-inl.h
@@ -687,13 +687,6 @@ Isolate* Heap::isolate() {
CALL_AND_RETRY_OR_DIE(ISOLATE, FUNCTION_CALL, return, return)
-#define CALL_HEAP_FUNCTION_PASS_EXCEPTION(ISOLATE, FUNCTION_CALL) \
- CALL_AND_RETRY(ISOLATE, \
- FUNCTION_CALL, \
- return __object__, \
- return __maybe_object__)
-
-
void ExternalStringTable::AddString(String* string) {
ASSERT(string->IsExternalString());
if (heap_->InNewSpace(string)) {
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
f2a4010ae34746e249bb78a6eb921ba47e2c2f09..72c5dbe87d06a7fae5f245f138b5e4bd993139db
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -843,18 +843,6 @@ Handle<Object> Object::GetProperty(Handle<Object>
object,
}
-MaybeObject* Object::GetPropertyOrFail(Handle<Object> object,
- Handle<Object> receiver,
- LookupResult* result,
- Handle<Name> key,
- PropertyAttributes* attributes) {
- Isolate* isolate = result->isolate();
- CALL_HEAP_FUNCTION_PASS_EXCEPTION(
- isolate,
- object->GetProperty(*receiver, result, *key, attributes));
-}
-
-
// TODO(yangguo): handlify this and get rid of.
MaybeObject* Object::GetProperty(Object* receiver,
LookupResult* result,
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
2020a8544f74bd3631cacccf391ee5dcb738e5f8..8d6d23e1fa4a951806d3cbf1659438a12fe36529
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1556,13 +1556,6 @@ class Object : public MaybeObject {
Handle<Name> key,
PropertyAttributes* attributes);
- MUST_USE_RESULT static MaybeObject* GetPropertyOrFail(
- Handle<Object> object,
- Handle<Object> receiver,
- LookupResult* result,
- Handle<Name> key,
- PropertyAttributes* attributes);
-
MUST_USE_RESULT MaybeObject* GetProperty(Object* receiver,
LookupResult* result,
Name* key,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
