Revision: 20451
Author:   [email protected]
Date:     Wed Apr  2 22:17:25 2014 UTC
Log:      MIPS: Make invalid LHSs that are calls late errors.

Port r20428 (7a071766)

Original commit message:
Necessary for web legacy compatibility.

Also fold in additional strict mode checks into LHS checks.
Minor constness clean-ups on the way.

BUG=
[email protected]

Review URL: https://codereview.chromium.org/222893002
http://code.google.com/p/v8/source/detail?r=20451

Modified:
 /branches/bleeding_edge/src/mips/full-codegen-mips.cc

=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Mon Mar 31 14:14:54 2014 UTC +++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Wed Apr 2 22:17:25 2014 UTC
@@ -1906,7 +1906,7 @@


 void FullCodeGenerator::VisitAssignment(Assignment* expr) {
-  ASSERT(expr->target()->IsValidLeftHandSide());
+  ASSERT(expr->target()->IsValidReferenceExpression());

   Comment cmnt(masm_, "[ Assignment");

@@ -2446,7 +2446,7 @@


 void FullCodeGenerator::EmitAssignment(Expression* expr) {
-  ASSERT(expr->IsValidLeftHandSide());
+  ASSERT(expr->IsValidReferenceExpression());

// Left-hand side can only be a property, a global or a (parameter or local)
   // slot.
@@ -4342,7 +4342,7 @@


 void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
-  ASSERT(expr->expression()->IsValidLeftHandSide());
+  ASSERT(expr->expression()->IsValidReferenceExpression());

   Comment cmnt(masm_, "[ CountOperation");
   SetSourcePosition(expr->position());

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to