Golem numbers (see Kraken benches that were affected by initial handlification):
http://108.170.219.2:8080/Comparison#targetA%3Dv8%3BmachineTypeA%3Dlinux-ia32%3BrevisionA%3D20446%3BpatchA%3Dishell-kraken-regression-fix%3BtargetB%3Dv8%3BmachineTypeB%3Dlinux-ia32%3BrevisionB%3D20446%3BpatchB%3DNone http://108.170.219.2:8080/Comparison#targetA%3Dv8%3BmachineTypeA%3Dlinux-x64%3BrevisionA%3D20446%3BpatchA%3Dishell-kraken-regression-fix%3BtargetB%3Dv8%3BmachineTypeB%3Dlinux-x64%3BrevisionB%3D20446%3BpatchB%3DNone On Thu, Apr 3, 2014 at 9:41 AM, <[email protected]> wrote: > Reviewers: Yang, > > Message: > PTAL > > > https://codereview.chromium.org/223413002/diff/1/src/factory.h > File src/factory.h (right): > > https://codereview.chromium.org/223413002/diff/1/src/factory.h#newcode341 > src/factory.h:341: } > This piece of code should be here from the beginning (r20156). I left it > in a general version of NewJSArray() by mistake. > > Description: > Partial recover from performance degradation after handlification of > ElementsAccessor::CopyElements (r20312). > > Please review this at https://codereview.chromium.org/223413002/ > > SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge > > Affected files (+122, -107 lines): > M src/builtins.cc > M src/elements.h > M src/elements.cc > M src/factory.h > M src/factory.cc > M src/objects.cc > > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
