LGTM once comments are addressed.
https://codereview.chromium.org/223413002/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/223413002/diff/1/src/builtins.cc#newcode364
src/builtins.cc:364: AllowHeapAllocation allow_allocation;
Add a comment that the callees return immediately afterwards
https://codereview.chromium.org/223413002/diff/1/src/builtins.cc#newcode637
src/builtins.cc:637: DisallowHeapAllocation
no_allocations_before_creating_result;
I would prefer if you still use scopes instead of interchanging
Disallow/Allow whenever possible. That would improve readability a lot
imo.
For example, scope this to go from line 637 to 714.
https://codereview.chromium.org/223413002/diff/1/src/builtins.cc#newcode730
src/builtins.cc:730: if (IsHoleyElementsKind(kind)) {
Then add a DisallowHeapAllocation scope here.
https://codereview.chromium.org/223413002/diff/1/src/builtins.cc#newcode746
src/builtins.cc:746: AllowHeapAllocation
allow_allocation_to_create_a_result;
This is now unnecessary.
https://codereview.chromium.org/223413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
