Mostly LG TM, just one comment.
https://codereview.chromium.org/222133003/diff/20001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/222133003/diff/20001/src/x64/macro-assembler-x64.cc#newcode1112
src/x64/macro-assembler-x64.cc:1112: if (SmiValuesAre32Bits()) {
We shouldn't be able to call Integer32ToSmiField on x32. Int32 obviously
doesn't fit in a smi, so this can overflow. The optimization of
requiring int32 for storing smi is only available to SmiValuesAre32Bits
from within Crankshaft already, so we should ASSERT that we don't end up
in this code-path in the other cases.
https://codereview.chromium.org/222133003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
