Revision: 20477
Author: [email protected]
Date: Thu Apr 3 12:23:35 2014 UTC
Log: Use premordial Object.isSealed/isFrozen in builtins.
[email protected]
Review URL: https://codereview.chromium.org/223473002
http://code.google.com/p/v8/source/detail?r=20477
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-builtinbust-1.js
Modified:
/branches/bleeding_edge/src/array.js
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-builtinbust-1.js
Thu Apr 3 12:23:35 2014 UTC
@@ -0,0 +1,14 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+function nope() { return false; }
+var a = [ 1, 2, 3 ];
+Object.seal(a);
+Object.isSealed = nope;
+
+assertThrows(function() { a.pop(); }, TypeError);
+assertThrows(function() { a.push(5); }, TypeError);
+assertThrows(function() { a.shift(); }, TypeError);
+assertThrows(function() { a.unshift(5); }, TypeError);
+assertThrows(function() { a.splice(0, 1); }, TypeError);
=======================================
--- /branches/bleeding_edge/src/array.js Wed Mar 12 13:42:18 2014 UTC
+++ /branches/bleeding_edge/src/array.js Thu Apr 3 12:23:35 2014 UTC
@@ -419,7 +419,7 @@
return;
}
- if ($Object.isSealed(this)) {
+ if (ObjectIsSealed(this)) {
throw MakeTypeError("array_functions_change_sealed",
["Array.prototype.pop"]);
}
@@ -460,7 +460,7 @@
var n = TO_UINT32(this.length);
var m = %_ArgumentsLength();
- if (m > 0 && $Object.isSealed(this)) {
+ if (m > 0 && ObjectIsSealed(this)) {
throw MakeTypeError("array_functions_change_sealed",
["Array.prototype.push"]);
}
@@ -596,7 +596,7 @@
return;
}
- if ($Object.isSealed(this)) {
+ if (ObjectIsSealed(this)) {
throw MakeTypeError("array_functions_change_sealed",
["Array.prototype.shift"]);
}
@@ -641,7 +641,7 @@
var len = TO_UINT32(this.length);
var num_arguments = %_ArgumentsLength();
- var is_sealed = $Object.isSealed(this);
+ var is_sealed = ObjectIsSealed(this);
if (num_arguments > 0 && is_sealed) {
throw MakeTypeError("array_functions_change_sealed",
@@ -654,7 +654,7 @@
if (IS_ARRAY(this) && !is_sealed) {
SmartMove(this, 0, 0, len, num_arguments);
} else {
- if (num_arguments == 0 && $Object.isFrozen(this)) {
+ if (num_arguments == 0 && ObjectIsFrozen(this)) {
// In the zero argument case, values from the prototype come into the
// object. This can't be allowed on frozen arrays.
for (var i = 0; i < len; i++) {
@@ -807,10 +807,10 @@
deleted_elements.length = del_count;
var num_elements_to_add = num_arguments > 2 ? num_arguments - 2 : 0;
- if (del_count != num_elements_to_add && $Object.isSealed(this)) {
+ if (del_count != num_elements_to_add && ObjectIsSealed(this)) {
throw MakeTypeError("array_functions_change_sealed",
["Array.prototype.splice"]);
- } else if (del_count > 0 && $Object.isFrozen(this)) {
+ } else if (del_count > 0 && ObjectIsFrozen(this)) {
throw MakeTypeError("array_functions_on_frozen",
["Array.prototype.splice"]);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
