On 2014/04/03 14:35:38, alph wrote:
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/223643004/diff/1/src/heap-snapshot-generator.cc#newcode1336
src/heap-snapshot-generator.cc:1336: MarkAsWeakContainer(transitions);
On 2014/04/03 13:31:34, ulan wrote:
> MarkTransitionArray visitor also visits Keys.
yes, I saw that. I'd like to address that in a separate patch.
AFAICT currently the keys are field names (Strings) so they should have
other
strong links.
OK, LGTM
https://codereview.chromium.org/223643004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
