Reviewers: Nico,
https://codereview.chromium.org/224443003/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/224443003/diff/40001/build/standalone.gypi#newcode195
build/standalone.gypi:195: 'cflags': [ '-Wall', '<(werror)', '-W',
'-Wno-unused-parameter',
Any idea why these settings are used "twice" in the Optdebug
configuration?
If you patch this into v8, and run ninja ia32.release, it'll create
out/ia32/{Release,Debug,Optdebug} and Debug and Optdebug only differ by
the settings in this section appearing twice, i.e.
cflags_cc is -Wnon-virtual-dtor -fno-rtti -Wnon-virtual-dtor -fno-rtti
Description:
wip
BUG=
Please review this at https://codereview.chromium.org/224443003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+24, -13 lines):
A + build.ninja
M build/features.gypi
M build/standalone.gypi
M build/toolchain.gypi
Index: build.ninja
diff --git a/test/intl/intl.status b/build.ninja
similarity index 65%
copy from test/intl/intl.status
copy to build.ninja
index
4ecbf325ada948674dd731a0fb0d87ea8824fb74..8e7b0901fef2859afc184546be76c29aa14a4362
100644
--- a/test/intl/intl.status
+++ b/build.ninja
@@ -1,4 +1,4 @@
-# Copyright 2013 the V8 project authors. All rights reserved.
+#Copyright 2014 the V8 project authors.All rights reserved.
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
@@ -25,18 +25,20 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+rule configure
+ description = Run GYP for $arch
+ command = PYTHONPATH=$$(pwd)/tools/generate_shim_headers:$$PYTHONPATH $
+ PYTHONPATH=$$(pwd)/build/gyp/pylib:$$PYTHONPATH $
+ GYP_GENERATORS=ninja $
+ build/gyp/gyp -Goutput_dir=out/$arch -Dv8_target_arch=$arch
--depth=. -Ibuild/standalone.gypi build/all.gyp
+ generator = 1
-# The following tests use getDefaultTimeZone().
-[
-[ALWAYS, {
- 'date-format/resolved-options': [FAIL],
- 'date-format/timezone': [FAIL],
- 'general/v8Intl-exists': [FAIL],
+build out/ia32/build.ninja: configure | build/all.gyp build/features.gypi
build/standalone.gypi build/toolchain.gypi samples/samples.gyp src/d8.gyp
test/cctest/cctest.gyp tools/gyp/v8.gyp
+ arch = ia32
- # TODO(jochen): The following test is flaky.
- 'overrides/caching': [PASS, FAIL],
+rule recurse
+ command = ninja -C out/$arch/$mode
- # BUG(2899): default locale for search fails on mac and on android.
- 'collator/default-locale': [['system == macos or arch == android_arm or
arch == android_ia32', FAIL]],
-}], # ALWAYS
-]
+build ia32.release: recurse | out/ia32/build.ninja
+ arch = ia32
+ mode = Release
Index: build/features.gypi
diff --git a/build/features.gypi b/build/features.gypi
index
85b8a38465cc3203233c1fa809c0a108280f711c..03be4e9f3bcf97067b1f59c7cd019af706f6665a
100644
--- a/build/features.gypi
+++ b/build/features.gypi
@@ -112,6 +112,9 @@
}],
],
}, # Debug
+ 'Optdebug': {
+ 'inherit_from': [ 'Debug' ],
+ },
'Release': {
'variables': {
'v8_enable_extra_checks%': 0,
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
e6f22cc24e804bc08127ebb65b9a3e088321c145..9f37cf5e36af100cd46b37bcef2662a599156a22
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -138,6 +138,9 @@
'Debug': {
'cflags': [ '-g', '-O0' ],
},
+ 'Optdebug': {
+ 'inherit_from': [ 'Debug' ],
+ },
'Release': {
# Xcode insists on this empty entry.
},
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
dc25036daa67c544e13c119e546d3c2862b7deb8..8d80dd16d8657aa02749970b65f89832aa34010c
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -613,6 +613,9 @@
}],
],
}, # Debug
+ 'Optdebug': {
+ 'inherit_from': [ 'Debug' ],
+ },
'Release': {
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
