Reviewers: Sven Panne,
Message:
Trivial one... PTAL
Description:
TypePrint() does not depend on Object::Print().
Please review this at https://codereview.chromium.org/225353004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -6 lines):
M src/types.h
M src/types.cc
Index: src/types.cc
diff --git a/src/types.cc b/src/types.cc
index
804ea5ece64d8a12941040014fb2300d5e59c2bd..9cab090695037aff9768a9a6c2de746ddbf050aa
100644
--- a/src/types.cc
+++ b/src/types.cc
@@ -568,7 +568,6 @@ Representation Representation::FromType(Type* type) {
}
-#ifdef OBJECT_PRINT
template<class Config>
void TypeImpl<Config>::TypePrint(PrintDimension dim) {
TypePrint(stdout, dim);
@@ -666,7 +665,6 @@ void TypeImpl<Config>::TypePrint(FILE* out,
PrintDimension dim) {
PrintF(out, ")");
}
}
-#endif
template class TypeImpl<ZoneTypeConfig>;
Index: src/types.h
diff --git a/src/types.h b/src/types.h
index
42a50b922bd0f0f56441d853687b4fd390466041..0d172bdf0eb9bc64514bbb1fc7caf2f426dc0285
100644
--- a/src/types.h
+++ b/src/types.h
@@ -293,11 +293,9 @@ class TypeImpl : public Config::Base {
static TypeHandle Convert(
typename OtherTypeImpl::TypeHandle type, Region* region);
-#ifdef OBJECT_PRINT
enum PrintDimension { BOTH_DIMS, SEMANTIC_DIM, REPRESENTATION_DIM };
void TypePrint(PrintDimension = BOTH_DIMS);
void TypePrint(FILE* out, PrintDimension = BOTH_DIMS);
-#endif
private:
template<class> friend class Iterator;
@@ -349,10 +347,8 @@ class TypeImpl : public Config::Base {
static int ExtendIntersection(
UnionedHandle unioned, TypeHandle t, TypeHandle other, int
current_size);
-#ifdef OBJECT_PRINT
static const char* bitset_name(int bitset);
static void BitsetTypePrint(FILE* out, int bitset);
-#endif
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
