LGTM
https://codereview.chromium.org/225983005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6078
src/api.cc:6078: CHECK(length <=
static_cast<size_t>(i::Smi::kMaxValue));
With the change below we should never hit this case, right? (Makes sense
to keep the check nevertheless.)
https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6110
src/api.cc:6110: return Local<Type##Array>();
\
nit: indentation (2 spaces is enough)
https://codereview.chromium.org/225983005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
