LGTM.
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc
File src/type-info.cc (left):
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc#oldcode499
src/type-info.cc:499: // Dictionary has been allocated with sufficient
size for all elements.
nit: Can we preserve this comment above the DisallowHeapAllocation
scope.
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc
File src/type-info.cc (right):
https://codereview.chromium.org/226623007/diff/1/src/type-info.cc#newcode498
src/type-info.cc:498: dictionary_, IdToKey(ast_id),
Handle<Object>(target, isolate()));
nit: Using "handle(target, isolate())" is shorter.
https://codereview.chromium.org/226623007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
