LGTM. Just one comment.
https://codereview.chromium.org/225183009/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/225183009/diff/1/src/objects.h#newcode1080
src/objects.h:1080: V(OrderedHashTable) \
Since the OrderedHashTable is just the abstract super-class of the
OrderedHashSet and OrderedHashMap, we really shouldn't have three
instance types here.
I am fine with sharing one map for both OrderedHashSet and
OrderedHashMap as the CL does right now. But then we should only add one
new instance type for now and drop the unused ones.
https://codereview.chromium.org/225183009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
