2 questions...if the answers are good, then
lgtm. :)
--Michael
https://codereview.chromium.org/227593003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/227593003/diff/1/src/runtime.cc#newcode2607
src/runtime.cc:2607: RUNTIME_ASSERT(size >= 0 && size <=
FixedArray::kMaxLength);
So you don't bother with !Smi::IsValid(size) because it's redundant,
right? (the CONVERT_SMI_ARG_CHECKED call should do that?
https://codereview.chromium.org/227593003/diff/1/src/runtime.cc#newcode2609
src/runtime.cc:2609: RUNTIME_ASSERT(args[2]->IsSmi());
Do args[1] and args[2] actually need to be smis?
https://codereview.chromium.org/227593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
