https://codereview.chromium.org/209473006/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/209473006/diff/80001/src/heap.cc#newcode5310
src/heap.cc:5310: v8::internal::Heap::FatalProcessOutOfMemory("invalid
array length", true);
On 2014/04/07 14:23:12, rmcilroy wrote:
On 2014/04/07 14:14:40, ulan wrote:
> Let's use ASSERT or CHECK instead of FatalProcessOutOfMemory because
it is not
> OOM.
I was following what AllocateRawFixedArray does with
FatalProcessOutOfMemory. I
can change it to CHECK if you prefer (not ASSERT though since I want
this to
happen in release too).
I would use CHECK in AllocateRawFixedArray too, but I see how it can be
connected to OOM: allocating a fixed array with kMaxLength elements
(128M elements) would likely cause OOM.
Here exceeding kMaxEntriesPerType (1K) is probably the result of a bug,
and is not related to OOM. So a simple CHECK seems more suitable.
https://codereview.chromium.org/209473006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
