lgtm with a nit:
https://codereview.chromium.org/227573002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/227573002/diff/1/src/api.cc#newcode3398
src/api.cc:3398: EXCEPTION_PREAMBLE(isolate);
MaybeHandle<> concept really helps!
https://codereview.chromium.org/227573002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/227573002/diff/1/src/runtime.cc#newcode5315
src/runtime.cc:5315: JSObject::SetElement(js_object, index, value, attr,
I would fix identation of this line.
https://codereview.chromium.org/227573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
