Thank you for review! I addressed comments and added arm64/x64.
Do we have performance measurements of how this impacts runtime?
ia32 didn't impact the benchmarks. I will run other archs.
https://codereview.chromium.org/215853005/diff/80001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):
https://codereview.chromium.org/215853005/diff/80001/src/ia32/builtins-ia32.cc#newcode1406
src/ia32/builtins-ia32.cc:1406: __
InvokeBuiltin(Builtins::STACK_OVERFLOW, JUMP_FUNCTION);
On 2014/04/08 11:58:40, Michael Starzinger wrote:
The assumption is that this invocation never returns, can we add an
int3() or
hlt() or something like to guard that?
Done.
https://codereview.chromium.org/215853005/diff/80001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/215853005/diff/80001/src/runtime.js#newcode472
src/runtime.js:472: function STACK_OVERFLOW(length) {
On 2014/04/08 11:58:40, Michael Starzinger wrote:
nit: I don't see a particular reason why we need to keep both of these
functions. But I agree that "STACK_OVERFLOW" is a better name, can we
drop
"APPLY_OVERFLOW" in favor of this one?
Done. Removed APPLY_OVERFLOW
https://codereview.chromium.org/215853005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
