https://codereview.chromium.org/227533006/diff/20001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/227533006/diff/20001/src/spaces.cc#newcode2026
src/spaces.cc:2026:
set_map_no_write_barrier(heap->raw_unchecked_free_space_map());
On 2014/04/08 13:00:53, jarin wrote:
Here we should do unsynchronized write of size and then release write
of the
map, no?
As it is written here, other threads could still see the new map with
a bogus
size.
Done.
https://codereview.chromium.org/227533006/diff/20001/src/spaces.cc#newcode2070
src/spaces.cc:2070:
Release_Store(reinterpret_cast<AtomicWord*>(address() + kNextOffset),
On 2014/04/08 13:00:53, jarin wrote:
What visibility does the Release_Store provide here?
I believe the free list is only manipulated "concurrently" under a
lock (in
FreeListCategory::Concatenate), so we should not need synchronization
here. (The
same goes for the line below.)
Done. Good point.
https://codereview.chromium.org/227533006/diff/30001/src/store-buffer.cc
File src/store-buffer.cc (right):
https://codereview.chromium.org/227533006/diff/30001/src/store-buffer.cc#newcode432
src/store-buffer.cc:432: HeapObject* object =
reinterpret_cast<HeapObject*>(*slot);
On 2014/04/08 13:00:54, jarin wrote:
Why could not we get rid of the read of *slot here and use old_value
instead?
Yes, this one should not be there. I did not upload the latest version.
All slot accessors are going through annotated load/stores.
https://codereview.chromium.org/227533006/diff/30001/src/store-buffer.cc#newcode437
src/store-buffer.cc:437:
slot_callback(reinterpret_cast<HeapObject**>(slot), object, old_value);
On 2014/04/08 13:00:54, jarin wrote:
This extra argument should not be necessary - we could make object =
old_value
here.
Done.
Good point, I was too conservative here.
https://codereview.chromium.org/227533006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
