Reviewers: jarin, Michael Starzinger,
Description:
Introduced Atomic8 and added no-barrier Atomic8 accessors.
BUG=
Please review this at https://codereview.chromium.org/228613005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+59, -0 lines):
M src/atomicops.h
M src/atomicops_internals_arm64_gcc.h
M src/atomicops_internals_arm_gcc.h
M src/atomicops_internals_mac.h
M src/atomicops_internals_mips_gcc.h
M src/atomicops_internals_tsan.h
M src/atomicops_internals_x86_gcc.h
M src/atomicops_internals_x86_msvc.h
Index: src/atomicops.h
diff --git a/src/atomicops.h b/src/atomicops.h
index
08be2a7d37088454add4b61e2e47f3bb9ba33e84..019e6406af7fbd243255f6aed77c3171805e396c
100644
--- a/src/atomicops.h
+++ b/src/atomicops.h
@@ -63,6 +63,7 @@
namespace v8 {
namespace internal {
+typedef char Atomic8;
typedef int32_t Atomic32;
#ifdef V8_HOST_ARCH_64_BIT
// We need to be able to go between Atomic64 and AtomicWord implicitly.
This
@@ -120,10 +121,12 @@ Atomic32 Release_CompareAndSwap(volatile Atomic32*
ptr,
Atomic32 new_value);
void MemoryBarrier();
+void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value);
void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value);
void Acquire_Store(volatile Atomic32* ptr, Atomic32 value);
void Release_Store(volatile Atomic32* ptr, Atomic32 value);
+Atomic8 NoBarrier_Load(volatile const Atomic8* ptr);
Atomic32 NoBarrier_Load(volatile const Atomic32* ptr);
Atomic32 Acquire_Load(volatile const Atomic32* ptr);
Atomic32 Release_Load(volatile const Atomic32* ptr);
Index: src/atomicops_internals_arm64_gcc.h
diff --git a/src/atomicops_internals_arm64_gcc.h
b/src/atomicops_internals_arm64_gcc.h
index
f6ed5de602695239e943a96ecb8744d22ae7cbff..254bba95ea422bd615d6fa0af1e40269225d2bbe
100644
--- a/src/atomicops_internals_arm64_gcc.h
+++ b/src/atomicops_internals_arm64_gcc.h
@@ -144,6 +144,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return prev;
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
*ptr = value;
}
@@ -162,6 +166,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
); // NOLINT
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return *ptr;
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return *ptr;
}
Index: src/atomicops_internals_arm_gcc.h
diff --git a/src/atomicops_internals_arm_gcc.h
b/src/atomicops_internals_arm_gcc.h
index
918920d02ae66e5723c0bb9993473be49f66036b..258a668da353753db9ce453fb677124a608b762f
100644
--- a/src/atomicops_internals_arm_gcc.h
+++ b/src/atomicops_internals_arm_gcc.h
@@ -311,6 +311,14 @@ inline Atomic32 Release_Load(volatile const Atomic32*
ptr) {
return *ptr;
}
+// Byte accessors.
+
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) { return *ptr; }
+
} } // namespace v8::internal
#endif // V8_ATOMICOPS_INTERNALS_ARM_GCC_H_
Index: src/atomicops_internals_mac.h
diff --git a/src/atomicops_internals_mac.h b/src/atomicops_internals_mac.h
index
4bd0c09bdfd4032970597540ac8f96a8156de2ad..80647f77fab137e4d8982d8b8a6d9d3992cb1f7c
100644
--- a/src/atomicops_internals_mac.h
+++ b/src/atomicops_internals_mac.h
@@ -93,6 +93,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return Acquire_CompareAndSwap(ptr, old_value, new_value);
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
*ptr = value;
}
@@ -107,6 +111,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
*ptr = value;
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return *ptr;
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return *ptr;
}
Index: src/atomicops_internals_mips_gcc.h
diff --git a/src/atomicops_internals_mips_gcc.h
b/src/atomicops_internals_mips_gcc.h
index
cb8f8b9d954e8cb37fa2d2f9c326607a846156f6..13112e024f59f8f50a5ac18217938d4d2c83b00f
100644
--- a/src/atomicops_internals_mips_gcc.h
+++ b/src/atomicops_internals_mips_gcc.h
@@ -136,6 +136,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return NoBarrier_CompareAndSwap(ptr, old_value, new_value);
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
*ptr = value;
}
@@ -154,6 +158,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
*ptr = value;
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return *ptr;
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return *ptr;
}
Index: src/atomicops_internals_tsan.h
diff --git a/src/atomicops_internals_tsan.h b/src/atomicops_internals_tsan.h
index
1819798a5d361d20a8e4df61fce6dda507da6522..ce5774efd2019ffe1cb6d3db5349a472298d3f9b
100644
--- a/src/atomicops_internals_tsan.h
+++ b/src/atomicops_internals_tsan.h
@@ -276,6 +276,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return cmp;
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ __tsan_atomic8_store(ptr, value, __tsan_memory_order_relaxed);
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
__tsan_atomic32_store(ptr, value, __tsan_memory_order_relaxed);
}
@@ -289,6 +293,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
__tsan_atomic32_store(ptr, value, __tsan_memory_order_release);
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return __tsan_atomic8_load(ptr, __tsan_memory_order_relaxed);
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return __tsan_atomic32_load(ptr, __tsan_memory_order_relaxed);
}
Index: src/atomicops_internals_x86_gcc.h
diff --git a/src/atomicops_internals_x86_gcc.h
b/src/atomicops_internals_x86_gcc.h
index
e58d598fbd4ea97cf84917bcafbde928626bfa04..1624b8238907afed62da0de405d1bd74f40909f1
100644
--- a/src/atomicops_internals_x86_gcc.h
+++ b/src/atomicops_internals_x86_gcc.h
@@ -107,6 +107,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return NoBarrier_CompareAndSwap(ptr, old_value, new_value);
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
*ptr = value;
}
@@ -152,6 +156,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
// See comments in Atomic64 version of Release_Store(), below.
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return *ptr;
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return *ptr;
}
Index: src/atomicops_internals_x86_msvc.h
diff --git a/src/atomicops_internals_x86_msvc.h
b/src/atomicops_internals_x86_msvc.h
index
ad9cf9d80bbf2804f9e853876c7dbb1f619cba95..6c7a22c44d236961bbbdfb480b00913b8af4f4ea
100644
--- a/src/atomicops_internals_x86_msvc.h
+++ b/src/atomicops_internals_x86_msvc.h
@@ -100,6 +100,10 @@ inline Atomic32 Release_CompareAndSwap(volatile
Atomic32* ptr,
return NoBarrier_CompareAndSwap(ptr, old_value, new_value);
}
+inline void NoBarrier_Store(volatile Atomic8* ptr, Atomic8 value) {
+ *ptr = value;
+}
+
inline void NoBarrier_Store(volatile Atomic32* ptr, Atomic32 value) {
*ptr = value;
}
@@ -114,6 +118,10 @@ inline void Release_Store(volatile Atomic32* ptr,
Atomic32 value) {
// See comments in Atomic64 version of Release_Store() below.
}
+inline Atomic8 NoBarrier_Load(volatile const Atomic8* ptr) {
+ return *ptr;
+}
+
inline Atomic32 NoBarrier_Load(volatile const Atomic32* ptr) {
return *ptr;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
