lgtm with nits:
https://codereview.chromium.org/229973004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352
src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(),
NULL));
Is it OK to return NULL instead of *receiver_handle here?
https://codereview.chromium.org/229973004/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/229973004/diff/1/test/cctest/test-heap.cc#newcode306
test/cctest/test-heap.cc:306:
Object::GetProperty(CcTest::i_isolate()->global_object(), name);
We can use |global| here instead of
CcTest::i_isolate()->global_object().
https://codereview.chromium.org/229973004/diff/1/test/cctest/test-heap.cc#newcode324
test/cctest/test-heap.cc:324:
Object::GetProperty(CcTest::i_isolate()->global_object(), obj_name);
And here.
https://codereview.chromium.org/229973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
