LGTM with nits
https://codereview.chromium.org/230463003/diff/1/src/types.h
File src/types.h (right):
https://codereview.chromium.org/230463003/diff/1/src/types.h#newcode300
src/types.h:300: bool IsInhabited() {
Nit: move this up to line 222
https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):
https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#newcode104
test/cctest/test-types.cc:104: for (int i = 0; i < 1000; ++i) {
We probably need to lower this somewhat. 500? 300?
https://codereview.chromium.org/230463003/diff/1/test/cctest/test-types.cc#newcode295
test/cctest/test-types.cc:295: typedef typename Types<Type, TypeHandle,
Region>::TypeList::iterator
You should be able to say T::TypeList::iterator here; similarly below.
https://codereview.chromium.org/230463003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
