LGTM, only nits left. Thanks for addressing my verbal comments already.
https://codereview.chromium.org/228923002/diff/40001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/228923002/diff/40001/src/heap.cc#newcode6372
src/heap.cc:6372: // On 64-bit platform(s), we put all code objects in a
2 GB range of
nit: The comment looks very outdated. Can we adapt it?
https://codereview.chromium.org/228923002/diff/40001/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/228923002/diff/40001/src/spaces.cc#newcode138
src/spaces.cc:138: size_t actual_requested = requested;
nit: Instead of having two variables "actual_requested" and "requested",
can we just mutate the latter in the condition below and drop the
former?
https://codereview.chromium.org/228923002/diff/40001/test/cctest/test-mark-compact.cc
File test/cctest/test-mark-compact.cc (right):
https://codereview.chromium.org/228923002/diff/40001/test/cctest/test-mark-compact.cc#newcode79
test/cctest/test-mark-compact.cc:79: heap->ConfigureHeap(2*256*KB, 1*MB,
1*MB, i::kIs64BitArch ? 512 * i::MB : 0);
nit: Shouldn't passing "0" here do the trick now?
https://codereview.chromium.org/228923002/diff/40001/test/cctest/test-mark-compact.cc#newcode104
test/cctest/test-mark-compact.cc:104: heap->ConfigureHeap(2*256*KB,
1*MB, 1*MB, i::kIs64BitArch ? 512 * i::MB : 0);
nit: Likewise.
https://codereview.chromium.org/228923002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
