Reviewers: Sven Panne,
Description:
Fix argument expectation Runtime_StringParseInt.
[email protected]
Please review this at https://codereview.chromium.org/230693002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+19, -1 lines):
M src/runtime.cc
A test/mjsunit/regress/regress-parseint.js
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index
e46fbba6474552121c7c2bcb105924276515658e..02024c1095be9237205d3dd7b003d0e0a22475c0
100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -6307,7 +6307,7 @@ RUNTIME_FUNCTION(MaybeObject*,
Runtime_StringParseInt) {
SealHandleScope shs(isolate);
CONVERT_ARG_CHECKED(String, s, 0);
- CONVERT_SMI_ARG_CHECKED(radix, 1);
+ CONVERT_NUMBER_CHECKED(int, radix, Int32, args[1]);
s->TryFlatten();
Index: test/mjsunit/regress/regress-parseint.js
diff --git a/test/mjsunit/regress/regress-parseint.js
b/test/mjsunit/regress/regress-parseint.js
new file mode 100644
index
0000000000000000000000000000000000000000..05501f31fdb17ace766ed20808adc6cdb611a50c
--- /dev/null
+++ b/test/mjsunit/regress/regress-parseint.js
@@ -0,0 +1,18 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function f(string, radix) {
+ // Use a phi to force radix into heap number representation.
+ radix = (radix == 0) ? radix : (radix >> 0);
+ if (radix != 2) return NaN;
+ return %StringParseInt(string, radix);
+}
+
+assertEquals(2, (-4294967294) >> 0);
+assertEquals(3, f("11", -4294967294));
+assertEquals(NaN, f("11", -2147483650));
+%OptimizeFunctionOnNextCall(f);
+assertEquals(3, f("11", -4294967294));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
