On 2014/04/09 13:51:47, ulan wrote:
https://codereview.chromium.org/230553004/diff/1/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):
https://codereview.chromium.org/230553004/diff/1/src/arm64/full-codegen-arm64.cc#newcode4853
src/arm64/full-codegen-arm64.cc:4853: STATIC_ASSERT(sizeof(bool) == 1);
//
NOLINT(runtime/sizeof)
On 2014/04/09 13:41:12, jbramley wrote:
> This is defined in the ABI for both ARM and AArch64. It's also true for
the
> simulator host environments I tested (gcc 4.8.1 on Ubuntu 13.10). If it
causes
> trouble, we'll have to review how we handle accesses to fields where the
size
is
> determined by the host environment. We might need templated Ldr/Str
variants
to
> load host data types, for example.
Another solution would be to change the type of "has_pending_message" to
something platform-independent, like int8_t or int32_t. Jochen, wdyt?
This probably isn't the only one, though. It would be nice if
ExternalReferences
could have an implicit access type, but due to the way they're used, that
would
be really hard to enforce.
https://codereview.chromium.org/230553004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
