Reviewers: danno, Jakob, Toon Verwaest, Paul Lind, kisg, kilvadyb, dusmil,
Message:
PTAL.
I've added a MIPS #ifdef around the new values in test-mark-compact.cc. Do
you
like this approach or should I just modify the values for all arch's?
Description:
MIPS: Adjust memory limits.
Increase memory limits due to larger code size on MIPS.
BUG=
Please review this at https://codereview.chromium.org/234153002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -0 lines):
M src/spaces.cc
M test/cctest/test-mark-compact.cc
Index: src/spaces.cc
diff --git a/src/spaces.cc b/src/spaces.cc
index
dfa9cea71a73a1f895da56237c1107c0e819c08b..75debc15ce668daedb6741e82347d9d637f6be9c
100644
--- a/src/spaces.cc
+++ b/src/spaces.cc
@@ -1084,6 +1084,9 @@ intptr_t PagedSpace::SizeOfFirstPage() {
size = AreaSize();
} else {
size = 480 * KB;
+#if V8_TARGET_ARCH_MIPS
+ size = size * 15 / 10; // Increase by 15% due to larger code size.
+#endif
}
break;
default:
Index: test/cctest/test-mark-compact.cc
diff --git a/test/cctest/test-mark-compact.cc
b/test/cctest/test-mark-compact.cc
index
25b30ef4e4840b7b1e442a50536a41f245f265ab..aa617c6016aebb7860f50c85a6052cd9608126d3
100644
--- a/test/cctest/test-mark-compact.cc
+++ b/test/cctest/test-mark-compact.cc
@@ -500,11 +500,20 @@ TEST(BootUpMemoryUse) {
CHECK_LE(delta, 4600 * 1024);
}
} else { // 32-bit.
+#if V8_TARGET_ARCH_MIPS
+ // Increase limits due to larger code size on MIPS.
+ if (v8::internal::Snapshot::IsEnabled()) {
+ CHECK_LE(delta, 3500 * 1024);
+ } else {
+ CHECK_LE(delta, 3800 * 1024);
+ }
+#else
if (v8::internal::Snapshot::IsEnabled()) {
CHECK_LE(delta, 3100 * 1024);
} else {
CHECK_LE(delta, 3450 * 1024);
}
+#endif
}
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
