https://codereview.chromium.org/225753004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/225753004/diff/1/src/parser.cc#newcode230
src/parser.cc:230: if (length % sizeof(unsigned) != 0) {
I think that silently (not) doing something is quite bad and will bite
us sooner or later. The corresponding API function has a way to
communicate failure by returning an empty handle, so this is what should
happen somehow. The question is how to communicate this through the
layers, failing in the constructor without having exceptions is ugly, so
one could e.g. use a factory method instead, but I'll leave the details
up to you. :-)
https://codereview.chromium.org/225753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
