Reviewers: Toon Verwaest,
Message:
Please take another look...
https://codereview.chromium.org/167303005/diff/150001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/167303005/diff/150001/src/objects.cc#newcode2028
src/objects.cc:2028: ? HeapType::OfCurrently(value, isolate)
On 2014/03/21 14:33:37, Toon Verwaest wrote:
If it's FORCE_TAGGED we also shouldn't be tracking types, right?
What about having a function that gets the representation in, in
addition to the
object? That way, if the representation is tagged, we don't track?
Done.
https://codereview.chromium.org/167303005/diff/150001/src/objects.cc#newcode2818
src/objects.cc:2818: new_descriptors->SetValue(modify_index,
*new_field_type);
No, we track types independent of the representation.
https://codereview.chromium.org/167303005/diff/150001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/167303005/diff/150001/src/objects.h#newcode1499
src/objects.h:1499: FLAG_track_heap_object_fields) && IsUninitialized())
{
This was a hack to work-around the "missing chokepoint for
generalization" issue. Fixed now.
https://codereview.chromium.org/167303005/diff/150001/src/property.h
File src/property.h (right):
https://codereview.chromium.org/167303005/diff/150001/src/property.h#newcode472
src/property.h:472: return GetFieldTypeFromMap(holder()->map());
ACK.
Description:
Field type tracking
Please review this at https://codereview.chromium.org/167303005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+617, -135 lines):
M src/arm/stub-cache-arm.cc
M src/arm64/stub-cache-arm64.cc
M src/deoptimizer.cc
M src/flag-definitions.h
M src/heap.cc
M src/hydrogen.h
M src/hydrogen.cc
M src/hydrogen-check-elimination.cc
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
M src/ia32/stub-cache-ia32.cc
M src/ic.cc
M src/json-parser.h
M src/objects.h
M src/objects.cc
M src/objects-debug.cc
M src/objects-inl.h
M src/property.h
M src/property.cc
M src/x64/stub-cache-x64.cc
A test/mjsunit/field-type-tracking.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
