It looks good; I just had one suggestion.
I think it's possible to avoid copy_receiver (and thus the branch over it)
by
speculatively copying the receiver before the Tbnz instructions, but this
doesn't make the code any smaller, and it might not be faster either.
https://codereview.chromium.org/226363007/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/226363007/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode5849
src/arm64/lithium-codegen-arm64.cc:5849: __ Mov(result, receiver);
You can skip this move now, and do __ B(ge, ©_receiver).
https://codereview.chromium.org/226363007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
