Revision: 20728
Author:   [email protected]
Date:     Mon Apr 14 13:52:41 2014 UTC
Log: Don't run tests that rely on compaction when compaction is turned off.

BUG=
[email protected]

Review URL: https://codereview.chromium.org/236203010
http://code.google.com/p/v8/source/detail?r=20728

Modified:
 /branches/bleeding_edge/test/cctest/test-api.cc
 /branches/bleeding_edge/test/cctest/test-heap.cc
 /branches/bleeding_edge/test/cctest/test-weakmaps.cc
 /branches/bleeding_edge/test/cctest/test-weaksets.cc

=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Mon Apr 14 08:27:00 2014 UTC +++ /branches/bleeding_edge/test/cctest/test-api.cc Mon Apr 14 13:52:41 2014 UTC
@@ -14182,6 +14182,7 @@
 UNINITIALIZED_TEST(SetJitCodeEventHandler) {
   i::FLAG_stress_compaction = true;
   i::FLAG_incremental_marking = false;
+  if (i::FLAG_never_compact) return;
   const char* script =
     "function bar() {"
     "  var sum = 0;"
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Mon Apr 14 11:19:37 2014 UTC +++ /branches/bleeding_edge/test/cctest/test-heap.cc Mon Apr 14 13:52:41 2014 UTC
@@ -2017,6 +2017,7 @@


 TEST(PrototypeTransitionClearing) {
+  if (FLAG_never_compact) return;
   CcTest::InitializeVM();
   Isolate* isolate = CcTest::i_isolate();
   Factory* factory = isolate->factory();
@@ -2891,6 +2892,7 @@


 TEST(ReleaseOverReservedPages) {
+  if (FLAG_never_compact) return;
   i::FLAG_trace_gc = true;
   // The optimizer can allocate stuff, messing up the test.
   i::FLAG_crankshaft = false;
@@ -3554,6 +3556,7 @@


 TEST(Regress168801) {
+  if (i::FLAG_never_compact) return;
   i::FLAG_always_compact = true;
   i::FLAG_cache_optimized_code = false;
   i::FLAG_allow_natives_syntax = true;
@@ -3610,6 +3613,7 @@


 TEST(Regress173458) {
+  if (i::FLAG_never_compact) return;
   i::FLAG_always_compact = true;
   i::FLAG_cache_optimized_code = false;
   i::FLAG_allow_natives_syntax = true;
=======================================
--- /branches/bleeding_edge/test/cctest/test-weakmaps.cc Wed Dec 18 08:09:37 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-weakmaps.cc Mon Apr 14 13:52:41 2014 UTC
@@ -180,6 +180,7 @@
// Test that weak map values on an evacuation candidate which are not reachable
 // by other paths are correctly recorded in the slots buffer.
 TEST(Regress2060a) {
+  if (i::FLAG_never_compact) return;
   FLAG_always_compact = true;
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
@@ -215,6 +216,7 @@
// Test that weak map keys on an evacuation candidate which are reachable by
 // other strong paths are correctly recorded in the slots buffer.
 TEST(Regress2060b) {
+  if (i::FLAG_never_compact) return;
   FLAG_always_compact = true;
 #ifdef VERIFY_HEAP
   FLAG_verify_heap = true;
=======================================
--- /branches/bleeding_edge/test/cctest/test-weaksets.cc Wed Dec 18 08:09:37 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-weaksets.cc Mon Apr 14 13:52:41 2014 UTC
@@ -180,6 +180,7 @@
// Test that weak set values on an evacuation candidate which are not reachable
 // by other paths are correctly recorded in the slots buffer.
 TEST(WeakSet_Regress2060a) {
+  if (i::FLAG_never_compact) return;
   FLAG_always_compact = true;
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
@@ -215,6 +216,7 @@
// Test that weak set keys on an evacuation candidate which are reachable by
 // other strong paths are correctly recorded in the slots buffer.
 TEST(WeakSet_Regress2060b) {
+  if (i::FLAG_never_compact) return;
   FLAG_always_compact = true;
 #ifdef VERIFY_HEAP
   FLAG_verify_heap = true;

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to