https://codereview.chromium.org/236143002/diff/60001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/236143002/diff/60001/src/factory.cc#newcode2003
src/factory.cc:2003: JSObject::SetProperty(result, value_string(),
value, NONE, SLOPPY).Assert();
I think you can skip all the JSObject machinery here and set these
properties directly into the object. I believe the syntax is:
result->InObjectPropertyAtPut(
JSGeneratorObject::kResultValuePropertyIndex, value);
result->InObjectPropertyAtPut(
JSGeneratorObject::kResultDonePropertyIndex, ToBoolean(done));
Seems like we might want to move those constants out of
JSGeneratorObject and into another class...not sure what the v8 folks
would want.
https://codereview.chromium.org/236143002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
