Reviewers: Michael Starzinger,
Message:
PTAL
https://codereview.chromium.org/237093006/diff/40001/src/factory.cc
File src/factory.cc (left):
https://codereview.chromium.org/237093006/diff/40001/src/factory.cc#oldcode1666
src/factory.cc:1666: Handle<JSFunction>
Factory::NewFunctionHelper(Handle<String> name,
one usage, inlined
https://codereview.chromium.org/237093006/diff/40001/src/factory.cc#oldcode1686
src/factory.cc:1686: Handle<JSFunction>
Factory::NewFunctionWithoutPrototypeHelper(
one usage, inlined
https://codereview.chromium.org/237093006/diff/40001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/237093006/diff/40001/src/factory.cc#newcode1743
src/factory.cc:1743: Handle<JSFunction>
Factory::NewFunctionHelper(Handle<Map> function_map,
Handlified Heap::AllocateFunction()
https://codereview.chromium.org/237093006/diff/40001/src/factory.h
File src/factory.h (left):
https://codereview.chromium.org/237093006/diff/40001/src/factory.h#oldcode398
src/factory.h:398: Handle<JSFunction> NewFunctionWithoutPrototype(
moved declaration down
https://codereview.chromium.org/237093006/diff/40001/src/factory.h#oldcode402
src/factory.h:402: Handle<JSFunction> NewFunction(Handle<Object> super,
bool is_global);
declaration only
https://codereview.chromium.org/237093006/diff/40001/src/factory.h#oldcode404
src/factory.h:404: Handle<JSFunction>
BaseNewFunctionFromSharedFunctionInfo(
one usage - inlined
https://codereview.chromium.org/237093006/diff/40001/src/factory.h#oldcode469
src/factory.h:469: Handle<JSFunction> NewFunction(Handle<String> name,
Moved these declarations up
https://codereview.chromium.org/237093006/diff/40001/src/factory.h#oldcode475
src/factory.h:475: Handle<JSFunction> NewFunction(Handle<Map>
function_map,
declaration only
Description:
Function allocators, Heap::ReinitializeJSGlobalProxy() and
Heap::ReinitializeJSReceiver() handlified. Factory::New<>() added.
Please review this at https://codereview.chromium.org/237093006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+190, -270 lines):
M src/bootstrapper.cc
M src/factory.h
M src/factory.cc
M src/handles.h
M src/handles.cc
M src/heap.h
M src/heap.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
