lgtm with nits:
https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/236193014/diff/40001/src/hydrogen.cc#newcode6833
src/hydrogen.cc:6833: handle(constant->map(), info->isolate()),
Suggestion: below we are also wrapping the map to a handle. What if we
do that only once?
https://codereview.chromium.org/236193014/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236193014/diff/40001/src/objects.cc#newcode11692
src/objects.cc:11692: // static
Some time ago I was pointed to the fact that we don't have a notation of
marking static functions with such a comments. Do we?
https://codereview.chromium.org/236193014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
