On 2014/04/15 08:32:49, marja wrote:
Btw, I just refactored ParseFunctionLiteral. Con: you'll need to rebase.
Pro:
The function is less monstrous now, so people are probably more willing to
accept additions. You might still want to refactor parsing the arguments
out
of
it. (Or I might.)
Precisely I was about to update this CL later today...
In the end I have split the code for arrow function parsing in a separate
ParserBase::ParseArrowFunctionLiteral() function, so rebasing now has gotten
much easier. I see in your commit that you have split out
SkipLazyFunctionBody()
and ParseEagerFunctionBody(), which can be used for arrow function bodies as
well... so I will do one more rebase and use those before updating the CL.
Thanks for the heads-up!
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
