On 2014/04/15 11:56:11, Jakob wrote:
LGTM with comment. Thanks!
https://codereview.chromium.org/238983002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):
https://codereview.chromium.org/238983002/diff/1/tools/push-to-trunk/releases.py#newcode172
tools/push-to-trunk/releases.py:172: "date": self.GitLog(n=1,
format="%cd",
git_hash=git_hash),
I'd prefer %ci:
$ git log -1 --format=%ci
2014-04-15 11:16:02 +0000
$ git log -1 --format=%cd
Tue Apr 15 11:16:02 2014 +0000
Done.
https://codereview.chromium.org/238983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
