LGTM. Adding Igor to CC to prevent him from redoing this.
https://codereview.chromium.org/239203003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7526
src/objects.cc:7526: Handle<Object> CodeCache::Update(
I think this can return void, since we don't need a MaybeObject to
signal allocation failure anymore.
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7547
src/objects.cc:7547: Handle<Object> CodeCache::UpdateDefaultCache(
Return void?
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7607
src/objects.cc:7607: Handle<Object> CodeCache::UpdateNormalTypeCache(
Return void?
https://codereview.chromium.org/239203003/diff/1/src/objects.cc#newcode7780
src/objects.cc:7780: Handle<CodeCacheHashTable> CodeCacheHashTable::Put(
Return void?
https://codereview.chromium.org/239203003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/239203003/diff/1/src/objects.h#newcode8347
src/objects.h:8347: Handle<CodeCacheHashTable> table,
please put each argument on its own line.
https://codereview.chromium.org/239203003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
