On 2014/04/15 14:55:18, ulan wrote:
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/239223003/diff/1/src/accessors.cc#newcode389
src/accessors.cc:389: const v8::PropertyCallbackInfo<void>& info) {
On 2014/04/15 14:50:35, Yang wrote:
> You could have one single setter that's unreachable, and call it
something
like
> IllegalCallback.
I use one macro to access both the getter and the setter from the field
name,
so
I need to define the setter. I can change that later on to use a different
macro
for read-only fields.
Lgtm
https://codereview.chromium.org/239223003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
