https://codereview.chromium.org/228943009/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/228943009/diff/1/src/objects.h#newcode1959
src/objects.h:1959: #if __BYTE_ORDER == __LITTLE_ENDIAN
On 2014/04/15 08:11:20, Jakob wrote:
Any reason this doesn't use V8_TARGET_LITTLE_ENDIAN?
It is used to keep consistency because there are other ifdef uses of
BYTE_ORDER in this file. I change all of them to check
V8_TARGET_LITTLE_ENDIAN and V8_TARGET_BIG_ENDIAN now.
https://codereview.chromium.org/228943009/diff/1/src/objects.h#newcode1959
src/objects.h:1959: #if __BYTE_ORDER == __LITTLE_ENDIAN
On 2014/04/15 08:11:20, Jakob wrote:
Any reason this doesn't use V8_TARGET_LITTLE_ENDIAN?
Done.
https://codereview.chromium.org/228943009/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/228943009/diff/1/test/mjsunit/mjsunit.status#newcode344
test/mjsunit/mjsunit.status:344: }], # 'arch == mipsel'
On 2014/04/15 08:11:20, Jakob wrote:
nit: update this comment please
Done.
https://codereview.chromium.org/228943009/diff/1/test/test262/test262.status
File test/test262/test262.status (right):
https://codereview.chromium.org/228943009/diff/1/test/test262/test262.status#newcode115
test/test262/test262.status:115: }], # 'arch == arm or arch == mipsel
or arch == arm64'
On 2014/04/15 08:11:20, Jakob wrote:
nit: update this comment please
Done.
https://codereview.chromium.org/228943009/diff/1/tools/testrunner/local/statusfile.py
File tools/testrunner/local/statusfile.py (right):
https://codereview.chromium.org/228943009/diff/1/tools/testrunner/local/statusfile.py#newcode56
tools/testrunner/local/statusfile.py:56: "arm", "arm64", "ia32", "mips",
"mipsel", "x64", "nacl_ia32", "nacl_x64",
On 2014/04/15 08:11:20, Jakob wrote:
nit: adjust the line break to keep 80col format
Done.
https://codereview.chromium.org/228943009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
