Revision: 20776
Author: [email protected]
Date: Tue Apr 15 15:29:23 2014 UTC
Log: JumpPatchSites can/should easily deal with uint8 sized offsets.
Motivation is that x64 nosnapshot builds need a 129 byte delta at the
moment.
[email protected]
Review URL: https://codereview.chromium.org/237673007
http://code.google.com/p/v8/source/detail?r=20776
Modified:
/branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
/branches/bleeding_edge/src/ia32/ic-ia32.cc
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
/branches/bleeding_edge/src/x64/ic-x64.cc
=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Fri Apr 11
07:27:25 2014 UTC
+++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Tue Apr 15
15:29:23 2014 UTC
@@ -74,7 +74,7 @@
void EmitPatchInfo() {
if (patch_site_.is_bound()) {
int delta_to_patch_site =
masm_->SizeOfCodeGeneratedSince(&patch_site_);
- ASSERT(is_int8(delta_to_patch_site));
+ ASSERT(is_uint8(delta_to_patch_site));
__ test(eax, Immediate(delta_to_patch_site));
#ifdef DEBUG
info_emitted_ = true;
=======================================
--- /branches/bleeding_edge/src/ia32/ic-ia32.cc Tue Mar 11 14:41:22 2014 UTC
+++ /branches/bleeding_edge/src/ia32/ic-ia32.cc Tue Apr 15 15:29:23 2014 UTC
@@ -1282,7 +1282,7 @@
Address delta_address = test_instruction_address + 1;
// The delta to the start of the map check instruction and the
// condition code uses at the patched jump.
- int8_t delta = *reinterpret_cast<int8_t*>(delta_address);
+ uint8_t delta = *reinterpret_cast<uint8_t*>(delta_address);
if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, test=%p, delta=%d\n",
address, test_instruction_address, delta);
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Fri Apr 11 07:27:25
2014 UTC
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Tue Apr 15 15:29:23
2014 UTC
@@ -74,7 +74,7 @@
void EmitPatchInfo() {
if (patch_site_.is_bound()) {
int delta_to_patch_site =
masm_->SizeOfCodeGeneratedSince(&patch_site_);
- ASSERT(is_int8(delta_to_patch_site));
+ ASSERT(is_uint8(delta_to_patch_site));
__ testl(rax, Immediate(delta_to_patch_site));
#ifdef DEBUG
info_emitted_ = true;
=======================================
--- /branches/bleeding_edge/src/x64/ic-x64.cc Fri Mar 28 04:55:00 2014 UTC
+++ /branches/bleeding_edge/src/x64/ic-x64.cc Tue Apr 15 15:29:23 2014 UTC
@@ -1303,7 +1303,7 @@
Address delta_address = test_instruction_address + 1;
// The delta to the start of the map check instruction and the
// condition code uses at the patched jump.
- int8_t delta = *reinterpret_cast<int8_t*>(delta_address);
+ uint8_t delta = *reinterpret_cast<uint8_t*>(delta_address);
if (FLAG_trace_ic) {
PrintF("[ patching ic at %p, test=%p, delta=%d\n",
address, test_instruction_address, delta);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
