Nice cleanup!
lgtm with nits:
https://codereview.chromium.org/236063016/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/236063016/diff/1/src/objects.cc#newcode3954
src/objects.cc:3954: void JSObject::WriteToField(int descriptor, Object*
value) {
Suggestion: you are not using handles here, what about adding
DisallowAllocationScope?
https://codereview.chromium.org/236063016/diff/1/src/objects.cc#newcode5205
src/objects.cc:5205: ASSERT(descriptors->GetType(sorted_index) ==
FIELD);
Does it make sense to move this assert to WriteToField?
https://codereview.chromium.org/236063016/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/236063016/diff/1/src/objects.h#newcode2910
src/objects.h:2910:
Extra empty line?
https://codereview.chromium.org/236063016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
