https://codereview.chromium.org/235153003/diff/20001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/235153003/diff/20001/src/factory.h#newcode417
src/factory.h:417: // by containing this pointer.
On 2014/04/16 11:10:04, Michael Starzinger wrote:
nit: s/this pointer/this handle/
Done.
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/235153003/diff/20001/src/heap.cc#newcode3874
src/heap.cc:3874: code->set_ic_age(global_ic_age_);
On 2014/04/16 11:25:39, Michael Starzinger wrote:
As per offline discussion: Let's also move these two initializations
into
NewCode, because they are not sufficient to get a consistent view of
the heap.
Hence if might be misleading to have the split apart.
Done.
https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips.h
File src/mips/assembler-mips.h (left):
https://codereview.chromium.org/235153003/diff/20001/src/mips/assembler-mips.h#oldcode1009
src/mips/assembler-mips.h:1009: // Allocate a constant pool of the
correct size for the generated code.
On 2014/04/16 11:10:04, Michael Starzinger wrote:
nit: Can we get the comment back?
Done.
https://codereview.chromium.org/235153003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
