I think the second issue might be related to changes in GetProperty API. It used to be a global function and now it is a static of Object (with different type signature).
I've created a new CL and I'm running it on the try servers now. On Tue, Apr 15, 2014 at 9:06 PM, <[email protected]> wrote: > On 2014/04/16 00:40:18, adamk wrote: > >> Committed patchset #11 manually as r20781 (presubmit successful). >> > > This got reverted in https://code.google.com/p/v8/source/detail?r=20782for > breaking the Win32 build due to some unresolved symbols: > > http://build.chromium.org/p/client.v8/builders/V8%20Win32% > 20-%20debug%20builder/builds/1521/steps/compile/logs/stdio > > Needs to be guarded with DECLARE_PRINTER(): > > 3>e:\b\build\slave\win-dbg-b\build\v8\src\objects.h(10115): warning > C4661: 'void > v8::internal::OrderedHashTableIterator<Derived,TableType>:: > OrderedHashTableIteratorPrint(FILE > *)' : no suitable definition provided for explicit template instantiation > request > > Needs forced instantiations: > > 10>test-dictionary.obj :error LNK2019: unresolved external symbol "public: > int > __thiscall v8::internal::OrderedHashTable<class > v8::internal::OrderedHashMap,class > v8::internal::JSMapIterator,2>::FindEntry(class v8::internal::Object *)" > (?FindEntry@?$OrderedHashTable@VOrderedHashMap@internal@v8@@ > VJSMapIterator@23@$01@internal@v8@@QAEHPAVObject@23@@Z) > referenced in function "void __cdecl `anonymous > namespace'::TestHashMap<class > v8::internal::OrderedHashMap>(class v8::internal::Handle<class > v8::internal::OrderedHashMap>)" > (??$TestHashMap@VOrderedHashMap@internal@v8@@@?A0xf5b4ac9d@@YAXV?$Handle@ > VOrderedHashMap@internal@v8@@@internal@v8@@@Z) > > 10>test-ordered-hash-table.obj :error LNK2019: unresolved external symbol > "public: static class v8::internal::Handle<class v8::internal::JSObject> > __cdecl > v8::internal::OrderedHashTableIterator<class v8::internal::JSSetIterator, > class > v8::internal::OrderedHashSet>::Next(class v8::internal::Handle<class > v8::internal::JSSetIterator>)" > (?Next@?$OrderedHashTableIterator@VJSSetIterator@internal@v8@@ > VOrderedHashSet@23@@internal@v8@@SA?AV?$Handle@VJSObject@internal@v8 > @@@23@V?$Handle@VJSSetIterator@internal@v8@@@23@@Z) > referenced in function "void __cdecl `anonymous namespace'::TestSet(void)" > (?TestSet@?A0x835bb4df@@YAXXZ) > > 10>test-ordered-hash-table.obj :error LNK2019: unresolved external symbol > "public: static class v8::internal::Handle<class v8::internal::JSObject> > __cdecl > v8::internal::OrderedHashTableIterator<class v8::internal::JSMapIterator, > class > v8::internal::OrderedHashMap>::Next(class v8::internal::Handle<class > v8::internal::JSMapIterator>)" > (?Next@?$OrderedHashTableIterator@VJSMapIterator@internal@v8@@ > VOrderedHashMap@23@@internal@v8@@SA?AV?$Handle@VJSObject@internal@v8 > @@@23@V?$Handle@VJSMapIterator@internal@v8@@@23@@Z) > referenced in function "void __cdecl `anonymous namespace'::TestMap(void)" > (?TestMap@?A0x835bb4df@@YAXXZ) > > > I don't understand: > > 10>test-ordered-hash-table.obj :error LNK2019: unresolved external symbol > "public: static class v8::internal::Handle<class > v8::internal::JSSetIterator> > __cdecl v8::internal::JSSetIterator::Create(class > v8::internal::Handle<class > v8::internal::OrderedHashSet>,int)" > (?Create@JSSetIterator@internal@v8@@SA?AV?$Handle@VJSSetIterator@internal > @v8@@@23@V?$Handle@VOrderedHashSet@internal@v8@@@23@H@Z) > referenced in function "void __cdecl `anonymous namespace'::TestSet(void)" > (?TestSet@?A0x835bb4df@@YAXXZ) > > 10>test-ordered-hash-table.obj :error LNK2019: unresolved external symbol > "public: static class v8::internal::Handle<class > v8::internal::JSMapIterator> > __cdecl v8::internal::JSMapIterator::Create(class > v8::internal::Handle<class > v8::internal::OrderedHashMap>,int)" > (?Create@JSMapIterator@internal@v8@@SA?AV?$Handle@VJSMapIterator@internal > @v8@@@23@V?$Handle@VOrderedHashMap@internal@v8@@@23@H@Z) > referenced in function "void __cdecl `anonymous namespace'::TestMap(void)" > (?TestMap@?A0x835bb4df@@YAXXZ) > > > https://codereview.chromium.org/236143002/ > -- erik -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
