Sorry, comments were lost - adding them
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7976
src/objects.cc:7976: Handle<FixedArray> AsHandle() {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
AsObject() method is quite simple, consider handlifying it as well.
AsObject() itself is a part of HashTable key contract, so can't be
handlified.
I could duplicate the logic in AsHandle but I prefer not to duplicate
the logic.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7987
src/objects.cc:7987: Handle<Code> code_;
On 2014/04/16 17:58:55, Igor Sheludko wrote:
You should use MaybeHandle<> here as the code could be null. The one
of the
goals is to remove Handle::is_null() completely.
Done.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode7991
src/objects.cc:7991: Object* CodeCacheHashTable::Lookup(Name* name,
Code::Flags flags) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
You are calling handlified code from non-handlified which is not safe
in
general. In this case it seems to be safe, so please put an
DisallowHeapAllocation scope here.
Done.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8003
src/objects.cc:8003: // Don't use |this|, as the table might have grown.
On 2014/04/16 17:58:55, Igor Sheludko wrote:
I think this comment is obsolete now.
Done.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode8016
src/objects.cc:8016: int CodeCacheHashTable::GetIndex(Name* name,
Code::Flags flags) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
Add DisallowHeapAllocation scope.
Done.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode14793
src/objects.cc:14793:
On 2014/04/16 17:58:55, Igor Sheludko wrote:
Add one more empty line here.
Done.
https://codereview.chromium.org/240023004/diff/20001/src/objects.cc#newcode15746
src/objects.cc:15746: Object* MapCache::Lookup(FixedArray* array) {
On 2014/04/16 17:58:55, Igor Sheludko wrote:
Add DisallowHeapAllocation scope.
Done.
https://codereview.chromium.org/240023004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
