LGTM with nits.
https://codereview.chromium.org/240323004/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/240323004/diff/1/src/accessors.cc#newcode777
src/accessors.cc:777: Isolate* isolate) {
I think the convention is (mostly) to have Isolate as first argument.
https://codereview.chromium.org/240323004/diff/1/src/accessors.cc#newcode808
src/accessors.cc:808: Isolate* isolate) {
Same here.
https://codereview.chromium.org/240323004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
