LGTM with nits.
https://codereview.chromium.org/240813002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/240813002/diff/1/src/objects.cc#newcode2539
src/objects.cc:2539: num_old_classes + num_new_classes <= 5 &&
Perhaps give the "5" a name...
https://codereview.chromium.org/240813002/diff/1/src/objects.cc#newcode2541
src/objects.cc:2541: return HeapType::Union(new_field_type,
old_field_type, isolate);
As discussed offline: Perhaps calculate the union first and then check
its size.
https://codereview.chromium.org/240813002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
