Reviewers: haitao.feng,
Message:
Thanks for pointing this out. PTAL.
Description:
X64: fix arguments adaptor stack check after r20751.
BUG=
Please review this at https://codereview.chromium.org/239703012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/x64/builtins-x64.cc
Index: src/x64/builtins-x64.cc
diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc
index
5803ad772318c98f1cfe3b5f15317e5312c4565c..19e7b533c9d425ed5062526818ae7f86e679db8d
100644
--- a/src/x64/builtins-x64.cc
+++ b/src/x64/builtins-x64.cc
@@ -1340,7 +1340,8 @@ static void
ArgumentsAdaptorStackCheck(MacroAssembler* masm,
__ subp(rcx, rdx);
// Make rdx the space we need for the array when it is unrolled onto the
// stack.
- __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rax, kPointerSizeLog2);
+ __ movp(rdx, rbx);
+ __ shlp(rdx, Immediate(kPointerSizeLog2));
// Check if the arguments will overflow the stack.
__ cmpp(rcx, rdx);
__ j(less_equal, stack_overflow); // Signed comparison.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.