[v8-dev] Issue 3274 in v8: PropertyCallbackInfo.This() should return Local instead of Local

Thu, 17 Apr 2014 02:56:22 -0700

Status: Accepted
Owner: [email protected]
CC: [email protected],  [email protected]
Labels: Type-Bug Priority-Medium

New issue 3274 by [email protected]: PropertyCallbackInfo.This() should return Local<Value> instead of Local<Object>
http://code.google.com/p/v8/issues/detail?id=3274

Tightening checks in Utils::OpenHandle (https://codereview.chromium.org/240113010) to check for object type when converting from API type to internal type causes assertion failure in Accessors::StringLengthGetter during snapshotting.

Reason is that the receiver object is a v8::String and therefore a v8::Value (corresponding to v8::internal::Object) and not a v8::Object (corresponding to v8::internal::JSObject). The code so far worked because in Accessors::StringLengthGetter we upcast it to v8::internal::Object*.

Changing PropertyCallbackInfo.This() to return Local<Value> seems non-trivial, since this affects the API.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to